neo-devpack-dotnet icon indicating copy to clipboard operation
neo-devpack-dotnet copied to clipboard

add example nep11

Open vikkkko opened this issue 1 year ago • 6 comments

vikkkko avatar Mar 29 '24 06:03 vikkkko

@vikkkko nice work, may you please use dotnet format to update the format?

Jim8y avatar Mar 29 '24 15:03 Jim8y

Change project name to non-divisible NEP11.

cschuchardt88 avatar Mar 30 '24 14:03 cschuchardt88

Make changes and You need to write tests in order to approve this.

Some tests will be added later.

vikkkko avatar Apr 01 '24 03:04 vikkkko

@AnnaShaleva please check it again, the name has being updated.

Jim8y avatar Apr 11 '24 09:04 Jim8y

please relove conflict @vikkkko

Jim8y avatar Apr 11 '24 09:04 Jim8y

All done. Ready for merge.

superboyiii avatar Apr 11 '24 10:04 superboyiii

@shargon All done

superboyiii avatar Apr 16 '24 10:04 superboyiii

this is an example and unnecessarily blocked the proposal. exception or assert all make sense, not worth a debating here. Thus, i will merge.

Jim8y avatar Apr 17 '24 00:04 Jim8y

this is an example

Yeah, this is an example and examples get copy-pasted into production code. Which means https://github.com/neo-project/neo-devpack-dotnet/pull/1009/files#r1562443533 will soon be in many C# NEP-11 implementations. And people will refer to this as the way to do things even though we know it's not the best one.

roman-khimov avatar Apr 17 '24 06:04 roman-khimov

this is an example

Yeah, this is an example and examples get copy-pasted into production code. Which means https://github.com/neo-project/neo-devpack-dotnet/pull/1009/files#r1562443533 will soon be in many C# NEP-11 implementations. And people will refer to this as the way to do things even though we know it's not the best one.

I can't agree more, an example in the official repository is not an example, it is a template

shargon avatar Apr 17 '24 07:04 shargon

Yeah, this is an example and examples get copy-pasted into production code. Which means https://github.com/neo-project/neo-devpack-dotnet/pull/1009/files#r1562443533 will soon be in many C# NEP-11 implementations. And people will refer to this as the way to do things even though we know it's not the best one.

I wont block your best one example practice if you have one in your mind. But blocking a pr without telling what is your best practice is not ok for me. And i sort of not believing there exists a best one example, discussion here more like either or.

Jim8y avatar Apr 18 '24 01:04 Jim8y