neo-one icon indicating copy to clipboard operation
neo-one copied to clipboard

Fix/remove special `manifest.serializeWireForNeo()` method

Open spencercorwin opened this issue 3 years ago • 1 comments

In the Neo repo you'll see that they serialize and deserialize the manifest in an odd way. So I had to create special manifest methods called serializeWireBaseForNeo and serializeWireForNeo. And in BinaryWriter: writeVarStringWithoutVar to mitigate this problem. I think this is the wrong way for Neo to implement this. There should be another byte in the beginning to indicate the variable length!

spencercorwin avatar Jun 16 '21 00:06 spencercorwin

Make sure that we are serializing and deserializing the manifest correctly as well

spencercorwin avatar Jun 16 '21 01:06 spencercorwin