Rene Saarsoo

Results 487 comments of Rene Saarsoo

I really would encourage you to add tests as early on as possible. You can start with just: ```ts import { format as originalFormat, FormatFn } from '../src/sqlFormatter.js'; import behavesLikeSqlFormatter...

Also, it would be of great help if you went through [the wiki](https://github.com/sql-formatter-org/sql-formatter/wiki) and added information there about the Clickhouse dialect. Especially these first few pages about Identifiers, Parameters, ......

I think with both of these it's best to consider which is the common way one would use a statement. Like the `DROP TABLE table1, table2, ...` syntax is supported...

Also, please run `yarn pretty`. The CI currently doesn't do that - should fix it.

The first issue happens because the comment is after a semicolon and the formatter uses semicolons to separate SQL statements with empty lines. This won't happen with comments that are...

Also, please don't report multiple different issues within one. It's really inconvenient to deal with. And I don't know why you chose to report this as a feature request -...

See the docs for [dialect](https://github.com/sql-formatter-org/sql-formatter/blob/master/docs/dialect.md#custom-dialect-configuration-experimental) config option.

Would be nice, yes. Unfortunately this happens because the formatter is unable to distinguish between `SET` in `UPDATE ... SET` and just plain `SET`. It does not understand context. So...

@KJlt77 you're either using an old version of sql-formatter or are not setting the dialect to MySQL. For me the above gets formatted as follows: ```sql CREATE DATABASE test DEFAULT...

Thanks for reporting. Unfortunately this is a problem that's pretty much impossible to fix with the current architecture of SQL Formatter. This is because `foo-bar.baz.zap` would have to be treated...