Rene Saarsoo comments

Results 487 comments of


                                            Rene Saarsoo

var function to class

Thanks for reporting. This should be fairly easy to fix. Though it does highlight a problem with the `arrow` transform, which is much more complex to fix.

var function to class

Aha... now that I look closer at this, I see that the main problem here is really the order in which the transforms are applied. - When you first apply...

var function to class

Order fixed now in the online tool.

var function to class

This likely isn't the right path for Lebab. - The recommended way of running Lebab is to use one transform at a time. This way, when something breaks, you can...

var function to class

Aha.. I see. This approach would indeed make more sense. Though I fail to see how it would solve any ordering issues. Well, I guess you can hard-code the order...

var function to class

Thanks for the explanation. I think I get the idea now. But for better or worse the approach of ESTraverse library is quite different from Babel/traverse. Most notably, ESTraverse provides...

refactor: migrate to `@babel/parser`

Thanks for the PR. See [the comment in #352 issue](https://github.com/lebab/lebab/issues/352#issuecomment-1890410437).

fix: empty destructuring with `var` should be converted to `const`

Thanks for bringing up this interesting corner-case. Does Babel actually generate code containing such empty destructuring cases or is it just an odd corner-case that the tests of Babel check?

Add a way to find out the original range of characters for an AST node

This would be really great to have. There are lots of applications for a parser where being able to reference the original source location is of crucial importance. I'm personally...

Added a configurable delay before filtering

Hi padraigdoran, unfortunately I haven't had time to review your pull request. But I still have plans of doing so. Just letting you know, so you won't think this repo...