Felicián Németh

Results 76 comments of Felicián Németh

@afontenot, thank you for your feedback. It seems there are more substantial issues with this PR at the moment. > Generally easier / more inclusive to discuss ideas in the...

> My initial concern is that the track list songlist often contains _thousands_ of songs, so an accidental ctrl-enter could make for a very long queue. I've pushed a new...

> Can you give an example of a specific case where this would make a difference? Is there anywhere in the LSP spec itself that mentions requiring these, or at...

Well, this is embarrassing. I cannot reproduce the bug. I use linux and I'm only able to observe the "relative URL without a base" error with an absolute path. This...

The "absolute path" bug is indeed fixed. However, the non-determinism remains. This is foo2.toml: ```toml #:schema asdf:///home/nemethf/src/taplo/bug/foo-schema.json foo = "bar" ``` And I use this one-liner to demonstrate the bug:...

> Does anyone see any other issues that would make this PR unmergeable? I've only looked at lsp-extensions.md, and it is not a showstopper for me, but there is a...

Eglot nowadays supports both php-mode and phps-mode. I'm afraid João is not a big fan of this idea, but instead of changing the default server, can you just follow the...

> @nemethf what exactly is the idea? > > Eglot supports any LSP server, the question here is what server to _suggest_ as the default 0-config one. For that, I'm...

> Do you see any drawback in this? No. The version on master is quite nice and concise. Thanks. @Sasanidas, @pablobc-mx: if you provide start commands for the new php...