Federico Capoano

Results 377 issues of Federico Capoano

**Is your feature request related to a problem? Please describe.** This is a follow up of https://github.com/openwisp/openwisp-notifications/issues/132 and https://github.com/openwisp/openwisp-notifications/issues/110, the idea is to allow users to configure the default settings...

enhancement

There's far too many occurrences of this task in some instances which pollutes the logs. If this task is meant to be used only for staff users, now is being...

bug

If a user is accessing the admin and has email notifications enabled, we should check whether the user has its email verified. If the email is not verified, we can...

enhancement

It would be great to add the capability of performing grammar checks on restructured text or markdown files (eg: README.rst, README.md or any text file in `docs/` directory). A quick...

enhancement

Lint errors are ignored: https://github.com/openwisp/ansible-openwisp2/blob/master/molecule/local/molecule.yml#L9-L12 This was probably forgotten. We need to move those checks from there to the `run-qa-checks` script, if there's no run-qa-checks script, we must add one...

bug

- Increase test coverage above 95% - Add selenium tests for at least 25% of the examples

enhancement

**Is your feature request related to a problem? Please describe.** It seems to me that changing objects via the REST API, like devices or templates , which in the admin...

enhancement

Flaky test: ``` ====================================================================== FAIL: test_unsaved_changes (openwisp_controller.config.tests.test_selenium.TestDeviceAdmin) [Alert should be displayed after making changes] ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/runner/work/openwisp-controller/openwisp-controller/openwisp_controller/config/tests/test_selenium.py", line 152, in test_unsaved_changes WebDriverWait(self.web_driver, 1).until(EC.alert_is_present()) File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/selenium/webdriver/support/wait.py",...

bug

Selenium tests contain JS errors due to failed websocket connection. We need to switch from django's `StaticLiveServerTestCase` to `ChannelsLiveServerTestCase`. I also recommend making the base selenium class in openwisp-utils automatically...

bug

Continuation of #290. - Allow staff users which are not superusers but have permission to change notification settings to open the view - Respect notification preferences permissions in RET API...

enhancement