Evan Nemerson
Evan Nemerson
Hi @rahulgo, thanks for your interest in contributing! Unfortunately it looks like most of the most straightforward functions are already implemented, but there are a few good first functions left,...
> Hello ! Is this still open ? I wanted to contribute to the project, was thinking maybe I can try implementing some of the functions. From what I understand...
Zhi's answer is correct, but here is a little more info which may help: Using meson to run a single test works, but the disadvantage is that it will actually...
It kind of depends on what you want to get out of the exercise. If you just want to add basic support, an implementation like madd/maddubs would work well enough...
> With regards to https://github.com/nemequ/simde/pull/295/checks?check_run_id=680612576#step:6:15 , was that supposed to be a negative test? @nemequ do you want negative (should fail to compile) tests? It would be nice, but it...
> sse4.2: added the implementation for mm_cmpestra > > I have created this PR from a new branch as old branch's commit history became very messy. > The implementation is...
The clang -Wsign-conversion diagnostic on the OpenMP pragma is interesting. I've filed [LLVM bug #45959](https://bugs.llvm.org/show_bug.cgi?id=45959). To work around it in SIMDe we can use something like: ```diff diff --git a/simde/simde-common.h...
This is why we have tests, and why it's so important that they be exhaustive. I didn't see anything wrong with the code on my previous reviews, either. > I...
These things often seem obvious in hindsight; I've spent hours on bugs simpler than this. Often you just need a fresh set of eyes; another person is great, but usually...
> I am confused about this again, isn't hitting the end of the string in mm_cmpestra is decided by `la` and `lb`, why we need to have 0 in the...