NelmioApiDocBundle icon indicating copy to clipboard operation
NelmioApiDocBundle copied to clipboard

defaultRouteDisabled to handle attributes

Open JohnstonCode opened this issue 1 year ago • 2 comments

fixes #2009

JohnstonCode avatar Jul 18 '22 13:07 JohnstonCode

Thank you @JohnstonCode for opening a pull request! Rather than instanciating all attributes, I'd feel more safe using the instanceof flag of getAttributes, to avoid loading broken attributes from other libraries (see https://www.php.net/manual/fr/reflectionclass.getattributes.php).

Would you be able to do the change?

GuilhemN avatar Aug 29 '22 21:08 GuilhemN

Yes ill make that change ASAP

JohnstonCode avatar Aug 30 '22 09:08 JohnstonCode

I've just hit this issue as well, is there any progress on this @JohnstonCode?

bobvandevijver avatar Nov 04 '22 12:11 bobvandevijver

@GuilhemN I have made the requested changes

JohnstonCode avatar Nov 06 '22 11:11 JohnstonCode

Thank you @JohnstonCode

GuilhemN avatar Jan 25 '23 17:01 GuilhemN