Nell Jerram
Nell Jerram
@sjh5205 Agreed, you can see the name that we are currently using here: ``` func getProgName(ifName string) string { return fmt.Sprintf("prefilter_%s_%s", xdpProgVersion, ifName) } ``` The `WipeXDP` function calls down...
Thanks @akosiaris and @caseydavenport for CCing me. FWIW, in Calico Enterprise we unconditionally added this at the top level: ``` protocol bfd { } ``` and then a `BGPPeer` field...
> is a compatible extension To be clear, I mean in terms of the data model. (I'm sure we will be able to do any fix-ups that are needed to...
All sounds good to me. For the avoidance of doubt, I believe we are only talking here about fixing up our coding to tolerate new args in some calls, and...
@sp3c1k As you probably know, we don't officially support Caracal yet. I think it will be more efficient for us to investigate this kind of issue when we take on...
@fasaxc While you're in the area, I wonder if you have any thoughts about https://github.com/projectcalico/calico/pull/9277 - i.e. about why our `make fix` doesn't make the changes that are proposed in...
@cuishuang We already have a mechanism for formatting in this repo, with `make fix`. It uses goimports, and I've just run it locally to see if it makes the same...
It seems we're already using the latest goimports (v0.25.0), so it's puzzling why that isn't already making these changes.
@caseydavenport Would you happen to know why goimports doesn't make these changes for us?
Our UTs are now OK with Caracal, but it looks like we have to update networking-calico to work with a newer version of etcd3gw (specifically, 2.4.0): ``` Sep 25 12:12:23...