Nelson Elhage

Results 67 comments of Nelson Elhage

Hm, `clobber` doesn't seem like the right test. How would you feel about either: - Changing the text to "ensuring table exists" - Guarding with a `if !db.table_exists?` ?

Modulo the concerns around making sure we don't update timestamps too early, I think this lgtm.

Thanks for this! I'd love to have at least some basic tests, though – is there anyone else on your team who might be able to help you out? I...

Thanks for the patchset! I'm super busy right now, but I'll try to look at this in more detail by early next week at the latest.

I'm fine taking this PR if you fix the things I've mentioned. I'd ideally like to see the code factored out so we have backend-specific adapters that implement a common...

Hey – I haven't looked at implement gridfs support, since I don't use it anywhere. I agree that adding support might be useful, and I'd consider a PR. It'd probably...

What happens if you try it with the `/dbname` URL and add `--skip-tail`? If you don't have admin access to the database you will be able to use the live-streaming...

Yeah, that could be fixed. The reason for that logic was that we use a single `collections.yaml` schema file for all of our replsets (each replset has a disjoin set...

We've definitely used that with success on 1.8.3. Have you verified that with `1.12.3` you're still hitting the primary (via `tcpdump` or `db.currentOp()` or whatever…)

have you patched it in your environment and verify that it works on 1.8 for you?