zigmod icon indicating copy to clipboard operation
zigmod copied to clipboard

add Fossil dep type

Open javierguerragiraldez opened this issue 3 years ago • 7 comments

javierguerragiraldez avatar Sep 01 '21 23:09 javierguerragiraldez

Wow, thanks for looking into this! The tests failing seem unrelated to this change so I'll get those fixed up and then get this merged in. 😄

nektro avatar Sep 02 '21 00:09 nektro

zigwin32 and hzzp are updated, still waiting on iguanatls

nektro avatar Sep 05 '21 02:09 nektro

Rebased this branch to master and looks all good to go.

Do we have a fossil repo hosted anywhere with some Zig code we can use to verify the functionality doesn't regress going forward?

nektro avatar Sep 15 '21 04:09 nektro

Do we have a fossil repo hosted anywhere with some Zig code we can use to verify the functionality doesn't regress going forward?

this is mine: http://chiselapp.com/user/javier/repository/zigqlite still haven't mastered how to declare dependencies on C libraries, but I have other (unpublished) project that depends on this one.

javierguerragiraldez avatar Sep 15 '21 04:09 javierguerragiraldez

Thanks! I'll give the repo a test and get this merged. Thanks again for pull this together :)

For C libraries you can see an example here https://github.com/nektro/zig-sqlite3/blob/master/zig.mod as well as the system_lib dep type

nektro avatar Sep 15 '21 04:09 nektro

One thing i'm noticing is that in the lockfile its always using the "commit" (in git speak). similarly, it makes me wonder if the fossil type should have equivalents for specifying "branch" or "tag" if those exist

nektro avatar Sep 23 '21 00:09 nektro

isn't the lockfile's purpose to "lock" the current version? the dependencies can use any way to specify a version (tag, branch, commit, or none), but the lockfile should use the exact commit... unless i'm missing something.

javierguerragiraldez avatar Sep 27 '21 16:09 javierguerragiraldez