zig-tracy icon indicating copy to clipboard operation
zig-tracy copied to clipboard

TracyClient.cpp compile error on Windows

Open SentientNr6 opened this issue 3 years ago • 5 comments

The author of tracy fixed this compilation error here https://github.com/wolfpld/tracy/issues/260

Not sure how you could fix it for zig-tracy since that one depends on the tracy 0.7.8 release.

Applying the fix locally works though.

SentientNr6 avatar Jan 22 '22 19:01 SentientNr6

Would it be feasible to point zig-tracy to that exact commit, and then fix any discrepancies that come up? That way we fix the issue while still pointing to a fixed Tracy version, even if it means requiring Tracy to be built from source by the user. We could also wait for another major Tracy release but it's been a while since that's happened.

cheeze42 avatar Feb 18 '22 23:02 cheeze42

are most people building tracy from source? if they're no longer making tags i could remove the version pin

nektro avatar Feb 19 '22 00:02 nektro

does zig cc still use mingw? Because apparently Tracy has since deprecated support for mingw entirely, according to their changelog, so it's possible that there would be issues using the latest tracy master.

cheeze42 avatar Feb 19 '22 06:02 cheeze42

mingw but zig cc allows both either mingw and msvc at the user's request

nektro avatar Feb 22 '22 03:02 nektro

Ah! As luck would have it Tracy 0.8 just released. So pointing at that version should fix the issue

cheeze42 avatar Mar 28 '22 22:03 cheeze42