Add 24.04 images, override -latest with -24.04

[keks]

Unfortunately the repo with the images hasn't updated their -latest tag in the last year, so we explicitly set it here.

Closes #2329

[codecov[bot]]

Codecov Report

:x: Patch coverage is 11.76471% with 15 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 74.74%. Comparing base (bd4bc99) to head (61c7349). :warning: Report is 27 commits behind head on master.

Files with missing lines	Patch %	Lines
cmd/root.go	0.00%	15 Missing :warning:

:x: Your patch check has failed because the patch coverage (11.76%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5951      +/-   ##
==========================================
+ Coverage   74.65%   74.74%   +0.09%     
==========================================
  Files          73       73              
  Lines       11139    11211      +72     
==========================================
+ Hits         8316     8380      +64     
- Misses       2186     2197      +11     
+ Partials      637      634       -3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Andrej730]

Don't want this go out of scope, but maybe there should be a warning in case someone has their latest in actrc pointing to 22.04? So users will be pointed towards resetting their actrc (either by removing it completely or removing -P lines from it) and updating latest in their config. Just came across this issue trying to switch to this fork.

[keks]

Wow you were faster than me. I added the warning that @Andrej730 asked for, but I am not sure it's where you'd like it to be.

[panekj]

The warning is wrong, as it will always trigger when using latest image

[keks]

The warning is wrong, as it will always trigger when using latest image

I think you were right that there was an issue, but it was a different issue.

The issue this PR solves is that catthehacker/ubuntu seems more or less unmaintained and ubuntu:act-latest and ubuntu:full-latest have been out of date for years. That's why we explicitly set it to ubuntu:act-24.04 and ubuntu:full-24.04. If the config still contains a setting that points ubuntu-latest to ubuntu:act-latest or ubuntu:full-latest, then we know it is out of date.

However, so far the warning only came for one of the image variants. I added checks for all of the default images. I also got rid of the HasPrefix - I thought this is needed because the string might contain a newline that would mess up a simple equality check, but now I see we are stripping arg of whitespace after taking it from the scanner.

[ChristopherHX]

The issue this PR solves is that catthehacker/ubuntu seems more or less unmaintained

Well we could fix this, we both have write access to the mentioned repository,

BTW I am a bit sceptical about everything you changed after my approval.

[keks]

Happy to revert all of the warning stuff, just wanted to make Andrej happy. I suppose the cleaner fix would be to update the container tag, but I can't do that in a PR.

[Andrej730]

The warning is not critical or anything, just wanted to avoid people stumbling upon the same issue and creating issues on why latest is still not pointing to 24.04.

[panekj]

-latest will point to 24.04 once this run completes: https://github.com/catthehacker/docker_images/actions/runs/19011364007/job/54292773341

[ChristopherHX]

bumped full-latest as well in the same repo

[Andrej730]

This can be closed?

[ChristopherHX]

Should be updated to not alert on latest tag and preserve them

override -latest with -24.04 #

only this should be reverted