fix: wrap subpath in '' (#2754)
- Fix #2754
before
[Check Spelling/Check Spelling] GoGitActionCache get content check-spelling/check-spelling with sha 001867346ea5ba54ea2660ec0d227ff5965813f8 subpath at /Users/jsoref/.cache/act/check-spelling-check-spelling.git
after
[Check Spelling/Check Spelling] GoGitActionCache get content check-spelling/check-spelling with sha 001867346ea5ba54ea2660ec0d227ff5965813f8 subpath '' at /Users/jsoref/.cache/act/check-spelling-check-spelling.git
Codecov Report
Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.
Project coverage is 74.65%. Comparing base (
bd4bc99) to head (8874785). Report is 4 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| pkg/runner/action_cache.go | 20.00% | 4 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #2755 +/- ##
=======================================
Coverage 74.65% 74.65%
=======================================
Files 73 73
Lines 11139 11147 +8
=======================================
+ Hits 8316 8322 +6
- Misses 2186 2190 +4
+ Partials 637 635 -2
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
I mean, I'd rather act use `...` instead of '...', but that's a larger discussion and yes, some extra quoting adventures would be involved.
This PR is just for general English readability and consistency.
Your patch check has failed because the patch coverage (42.85%) is below the target coverage (50.00%)
I do not think we can run old and new actions cache tests in nektos/act (would double the test duration), so coverage is a problem....
my own version has removed the old actions cache, like I planned for nektos/act and has much better coverage for these Line of Code. We would need help from cplee to bypass this check.
I'd rather remove Codecov (or disable CI failure for it), I know it feels nice that numbers go up for good things but we are not a corporation that has to deliver certain quality, just few people trying to make things better. It would be better if it just reported coverage without killing contributions.