Neil Isaac

Add From and Into support for SystemTime using references

3

Enable conversions between Timestamp and SystemTime using references without cloning, and add support for SystemTime::from(Timestamp) in addition to Into (which is derived from the From implementations) Refer to the note...

Non-deterministic results for overlapping overrides

4

Source::collect returns a config::Map which is a HashMap. HashMap traversals are unordered, so the processing order of a Source is non-deterministic. This can be an issue if multiple values in...

There was a bug in the workaround for eabihf support. I'm not sure whether backwards compatibility is required or not. These platforms were working in a previous version of rules_rust.

Only add coverage instrumentation to tests

1

Linking a rust_shared_library with ld.gold fails when building a rust_shared_library that exposes FFI bindings used in a coverage build of a test written in another language.

rust: expose api to write messages directly

2

Currently Writer::write_to_known_channel takes a byte slice argument, so messages must be encoded into a buffer before writing to the log. In order to efficiently write protobuf messages to mcap (https://github.com/foxglove/mcap/issues/688)...

rust: optional protobuf schema and direct protobuf message writing support

4

Encoding protobuf message in mcap logs is a common use case that could be streamlined. Currently a file descriptor set must be assembled and write to the schema manually, and...

Support for return_const Option<&T> and Result<&T, E>

7

Mocking a trait method `fn foo(&self) -> Option` is difficult because return_const wants `Option`, so the mock doesn't own the value. It would be more useful if return_const would accept...

When linking a rust_shared_library that depends on a bindgen_rust_library, I get errors such as: ``` /usr/bin/ld.gold: error: /.../some_rust_binding.rlib(some_c_lib.o): requires dynamic R_X86_64_PC32 reloc against '_ZNSs4_Rep20_S_empty_rep_storageE' which may overflow at runtime; recompile...

When linking a rust_shared_library that depends on a bindgen_rust_library, I get errors such as: ``` /usr/bin/ld.gold: error: /.../some_rust_binding.rlib(some_c_lib.o): requires dynamic R_X86_64_PC32 reloc against '_ZNSs4_Rep20_S_empty_rep_storageE' which may overflow at runtime; recompile...

A previous version of rules_rust seemed to support this platform, however it is not currently included. https://github.com/bazelbuild/rules_rust/pull/2350