Damien Neil
Damien Neil
@rhysh > Does an endpoint that acts as a client need to set a certificate? No; fixed the documentation for `Config.TLSConfig`. ---- > ``` > func (s *Stream) ReadContext(ctx context.Context,...
> just setup the quic listener and pass it to http.Serve. To be clear: This will not work. QUIC is not TCP. A `quic.Listener` listens for QUIC connections, where a...
Unreliable datagrams (RFC 9221) are something we definitely want to support, although I'd rather defer that to a separate proposal. A `net.PacketConn`-style API may not suffice, since we may want...
U+DCA0 is a Unicode surrogate, and should not appear in valid UTF-8 text. A conformant UTF-8 decoder is required to reject input containing an unpaired surrogate; see "How do I...
Yes, you're right; I wasn't looking at the error message. The error is definitely wrong, or at least confusing. Also, the protojson parser expects a surrogate to be followed by...
You'd also want to rename the types in the `proto`, `encoding/prototext`, and `encoding/protojson` packages. It's been a while, but I think we went with `MarshalOptions`/`UnmarshalOptions`, because the older proto package...
Since message, map, and repeated fields don't have default values, I think you could interpret "default values" in the proto3 JSON specification as referring to the zero values of primitive...
For extensions, I'd expect `IgnoreUnsetFields(want)` to ignore any extensions not set in `want`. I think that might require some additional handling beyond @stapelberg's implementation above. The `messagediff` package (Google-internal) was...
> Are you referring to https://github.com/protocolbuffers/protobuf/blob/main/src/google/protobuf/util/message_differencer.h perhaps? It is a C++ message diffing library with partial comparison support. Yes, that's the one. The Google-internal `messagediff` package was my attempt at...
The standard library `cmp` is obviously not being renamed. We could rename `github.com/google/go-cmp/cmp`. But that's a lot of churn and confusion, for a questionable benefit. I think the best thing...