Nehal Patel

Results 40 comments of Nehal Patel

Oh, I see. I will bring this up in our handoff meeting today.

Might be related: https://github.com/flutter/flutter/issues/102402

Update rescheduleUsingCheckRunEvent with logic that differentiates presubmit and postsubmit - `getTryBuilds` + `_createPresubmitScheduleBuild` - `getProdBuilds` + `_createPostsubmitScheduleBuild`

The tricky part is how to know if it's a postsubmit or presubmit checkrun. Tentative plan: One way is to add a datastore check here when the `rerequested` event is...

### Manual workflow: I was able to run the manual workflow with curl on my test repo and it worked. I've attached screenshots here. ## 1 - curl - Create...

I believe the main reason is there are two discrete code paths to take to launch the new attempt/build, depending on if the run is pre/post submit. - If presubmit:...

I checked a bunch of logged `rerequested` events for different repos and here's what I found: **presubmit**: - pull_requests is empty (flutter/flutter) - pull_requests is empty (flutter/engine) - pull_requests is...

One alternative I could think of is to pre-empt the upcoming refactor and add a new column to the datastore that identifies the task as presubmit/postsubmit/etc. Right now, every task...

Still tracking this. I'll be discussing this further with the team this week and post updates.