Nic Cope

Just got this to fail locally. It looks like the provider is installed, but not in the lock... ``` # kubectl get provider.pkg NAME INSTALLED HEALTHY PACKAGE AGE crossplane-contrib-provider-nop True...

This is interesting. I noticed provider-nop v0.3.1 existed and was the active revision. I edited it to add an annotation to kick off a reconcile, and it added itself to...

I added some logging: ```diff --- a/internal/controller/pkg/revision/dependency.go +++ b/internal/controller/pkg/revision/dependency.go @@ -31,6 +31,7 @@ import ( "sigs.k8s.io/controller-runtime/pkg/client" "github.com/crossplane/crossplane-runtime/pkg/errors" + "github.com/crossplane/crossplane-runtime/pkg/logging" "github.com/crossplane/crossplane-runtime/pkg/resource" pkgmetav1 "github.com/crossplane/crossplane/apis/pkg/meta/v1" @@ -63,14 +64,16 @@ type PackageDependencyManager struct {...

The PR that introduced the different-source check: https://github.com/crossplane/crossplane/pull/5946

Not sure how this is happening... If changing the source results in a new OCI digest (e.g `crossplane-contrib/provider-nop:v0.4.0` -> `xpkg.crossplane.io/crossplane-contrib/provider-nop:v0.3.1`) that should result in two package revisions. The package reconciler...

https://github.com/crossplane/crossplane/blob/09e27bdb1e25c0f839a58685c2ff99768b75320d/test/e2e/pkg_test.go#L488-L492 https://github.com/crossplane/crossplane/blob/09e27bdb1e25c0f839a58685c2ff99768b75320d/test/e2e/manifests/pkg/dependency-upgrade/downgrade/package/crossplane.yaml#L15-L18 https://explore.ggcr.dev/fs/xpkg.crossplane.io/crossplane/e2e-depends-on-provider-nop@sha256:e19cd5c9aa6701974c56aa819a9d784290366a353976264eb053b0160ab401b3/package.yaml It looks like the configuration the (sometimes) failing test installs: * Depends directly on `xpkg.crossplane.io/crossplane-contrib/provider-nop

We could address the specific case this E2E test is hitting by teaching the check added in https://github.com/crossplane/crossplane/pull/5946 about the default registry, so that it knows `xpkg.crossplane.io/a/b` and `a/b` are...

> I think it's related with this [comment](https://github.com/crossplane/crossplane/pull/6014/files#r1804909790). @ezgidemirel FWIW it wasn't missing for a short period, and one of the revisions was definitely active. It was missing until I...

(From @ezgidemirel on Slack): > one suggestion I have is to normalize packages to the repository/image-name format within the Identifier() method and ensure that this method is used consistently across...

Thanks, good catch. It's automated so I wonder why/how it's missing them...