Nic Cope
I've finally opened a design PR for this: https://github.com/crossplane/crossplane/pull/6557.
Cross ref https://github.com/crossplane/crossplane/blob/5e3abc1/design/one-pager-composition-revisions.md#garbage-collection
/fresh Not sure how urgent this is, but we do need to do it at some point.
Help still wanted. 🙂 I suggest implementing this by adding a controller that runs periodically and deletes everything other than the latest N revisions. Perhaps N should be configurable, but...
@bobh66 I'm not sure I understand the case you're thinking about. If the XR has a valid composition revision selector I'd expect it to successfully select a revision. That revision...
@bobh66 I'm assuming we'd keep around the N most recent revisions of a particular Composition, even if nothing used them. Would that address the concern?
Yeah. The issue is that we don't restart the XR controller when the XRD is updated, and iirc the allowed secret keys are passed as arguments when we start the...
XRs won't have connection secrets in v2 per https://github.com/crossplane/crossplane/pull/6473. They still do in v1 legacy XRs, so we could fix this there. I'm not sure it's high priority though.