Nic Cope

Results 846 comments of Nic Cope

FYI - replacing the stale bot per https://github.com/crossplane/crossplane/issues/3046#issuecomment-1219974924.

I would expect issues like this to show up as: * A status condition on the XR (note - not Composition) * An event on the XR (note - not...

I'm slightly second guessing the good first issue label, but I'll leave it there for someone who wants a possibly kinda tricky good first issue. If this is indeed not...

Is there any upstream machinery that could help with this? In particular I suspect we're overdue to move to server-side apply which appears to have 'built in' support for merge...

@muvaf I don't disagree - my point is that I'm wary of continuing to "reinvent the wheel" by teaching our client-side patching logic how to do what it seems SSA...

I think we should be biasing for moving toward SSA rather than extending (further diverging) our client-side patching logic. > But if there isn't, it's a huge overhead to have...

Thanks for digging deep into this @muvaf. I continue to feel that our ultimate goal should be to migrate to SSA. I can see that it might be unrealistic to...

@lavalamp Thanks, that helps - at least being able to align on the same format. We're currently using a similar package - https://github.com/crossplane/crossplane-runtime/tree/master/pkg/fieldpath. We'd probably have used the one you...

Would it make more sense to clear out the claim's `resourceRef` so that it can create a new XR name in this scenario? I like that this would make it...

> since the XR name is often used as base for the MR name, the existing resources wouldn't be picked up. I think I'm missing something here. Could you maybe...