Nic Cope

Results 846 comments of Nic Cope

Sorry I've been swamped and am just now trying to catch up with some PRs. 😄 At a glance this LGTM - can you rebase though? We recently updated main...

@daniel-maganto I'm having a hard time following the problem. It looks like you're applying a manifest with keys, but no values. It seems like the problem you're seeing is that:...

> now If I am removing optional from claim it is reomved from xr but it is not removed from mr . Are you using composition functions, or native P&T,...

@jankaacc I recommend migrating to https://github.com/crossplane-contrib/function-patch-and-transform/. This will get you end-to-end server-side apply. We probably won't update native P&T to use server-side apply, because we're likely to deprecate it per...

I like the idea of a webhook that rejects provider deletes while at least one of its CRs (MRs, ProviderConfigs, etc) still exist. Is that something you'd be interested in...

I think this is fairly high priority to address. I worry that folk'll compose cluster scoped resources (e.g. legacy MRs) without knowing they shouldn't. If they take a dependency on...

Yeah, I haven't had a chance to think much about this but I assume you're right. We'd need to: 1. Render all resources 2. Check whether any of the resulting...

Alternatively a workaround could be that folks migrating just use a slightly older `crossplane` binary, e.g. one built from v1.20.

The function shouldn't be updating the resource version unless it's actually changing something about the resource. Kubernetes uses the resource version for optimistic concurrency - it increments it whenever something...

* https://github.com/crossplane/crossplane/issues/6245 I'd like to add the above as a sub-issue here but an issue can only have one parent. 🙁 I'd rather it be parented to the over-all E2E...