Nic Cope
Nic Cope
@andriipetruk Thanks! You'll need to sign your commit before we can merge this. See https://github.com/crossplane/crossplane/pull/3334/checks?check_run_id=8458001764 for details.
> Instead of referencing a generated name for the compositionRevisionRef, it would be simpler to reference the Composition name plus revision number, like example-1 One interesting challenge here is that...
@jbhennin just raised this at this week's community meeting. I'd like to get some more community input on this to make sure we arrive at a solution that works for...
I wonder if it would make sense to address this with a `compositionRevisionSelector` (similar to `compositionSelector`, but only for revisions of the already-selected `Composition`). I could imagine this working something...
> another suggestion could be to use a hash as suffix instead of a random generated value. > this would have the benefit that a specific revision will have the...
I'm going to "sleep on" this for the weekend but I'm inline to just go ahead and merge. It seems like a violation to share API types, but it would...
> Maybe it makes sense to overthink the design of CompositionRevision again @MisterMX Personally I would prefer not to make CompositionRevision an opaque bag of JSON - I dropped a...
> I noticed in https://github.com/crossplane/crossplane/issues/3274 that the idea of generating copies of the structures in v1 was discussed. FWIW that is still my preferred approach.
I'm going to close this since we're reluctant to proceed with the approach. Definitely copying at build time would be ideal, but as far as I know there's no tool...
I feel like another good place for web hooks to slot in would be something like `provider-webhook` that could be used with custom composition to basically call an arbitrary REST...