meme-box icon indicating copy to clipboard operation
meme-box copied to clipboard

Feature: add https://www.transition.style transitions

Open negue opened this issue 4 years ago • 4 comments

negue avatar Jun 30 '21 23:06 negue

Greetings! This seems to be an interesting issue. I am an IT student currently a Junior at IGDTUW and I would love to contribute to this issue. Can you please provide with some more details about this? Thank-you and have a great day!

pooja-gera avatar Oct 04 '21 09:10 pooja-gera

Hey!

I think I should create those issues with more informations haha.

Currently the animations that are added are from https://animate.style/:

  • the syles import are in styles.scss
  • each animation are added in animations.ts

while writing this, I saw that https://www.transition.style aren't using class names, but this instead:

<div transition-style="in:circle:bottom-right">
  A transitioned IN element
</div>

I think those animations still could be added in te those arrays in animations.ts , but it would need to be some different logic in media-toggle.directive.ts ( startAnimation , removeAnimation)
so instead of adding the classes - it needs to add this transition-style to the element instead

Hope this helps to explain the scope of this issue / feature

negue avatar Oct 04 '21 16:10 negue

Haha, I am sorry if I made you work extra. This sounds fun, can I work on this one?

pooja-gera avatar Oct 05 '21 07:10 pooja-gera

Yeah sure, feel free to try this feature out :)

Ping me if there is something unclear

negue avatar Oct 05 '21 10:10 negue