Easy-Transformer icon indicating copy to clipboard operation
Easy-Transformer copied to clipboard

[Proposal] Allow recent versions of beartype

Open jettjaniak opened this issue 1 year ago • 6 comments

Proposal

Allow beartype>=0.15.0 in project dependencies

Motivation

It's hard and hacky to get a project setup that depends on TL and recent version of beartype

Pitch

change beartype==^0.14.1 to beartype>=0.14.1

Alternatives

change beartype==^0.14.1 to beartype==^0.18.5

Checklist

  • [x] I have checked that there is no similar issue in the repo (required)

jettjaniak avatar Jul 10 '24 14:07 jettjaniak

Someone has inadvertently experimented with this, and it does seem like it is not going to be a trivial process. I don't know if it is going to be the most complicated task in the project, but there are quite a few pieces that need to be addressed. @jettjaniak Have you been able to find a relatively simple way to get everything working together, or is the current bear type version blocking a lot of productivity?

bryce13950 avatar Jul 22 '24 18:07 bryce13950

I'm using TL with new beartype version, it's working fine

jettjaniak avatar Jul 23 '24 09:07 jettjaniak

@jettjaniak It may have been a different dependency that I am thinking of. I will try to update it to 0.18 now, and see if we have any major issues with that update.

bryce13950 avatar Jul 23 '24 17:07 bryce13950

Alright! I think I was recalling a different tool when I posted my first comment. This upgrade was pretty trivial. It did require an update to dependencies for torch, so I am going to wait until the next feature release to put this into pip. If you need it right away, it will be in dev once the CI is done. The next feature release will be sooner rather than later though.

bryce13950 avatar Jul 23 '24 18:07 bryce13950

Well it was actually mypy that was the issue for the dependency update! That is still an issue, so I am reopening this one until those mypy changes are resolved.

bryce13950 avatar Jul 23 '24 18:07 bryce13950

Thanks! So dev TL works with recent beartype now, but not with recent mypy?

jettjaniak avatar Jul 24 '24 19:07 jettjaniak