Easy-Transformer icon indicating copy to clipboard operation
Easy-Transformer copied to clipboard

[Proposal] Documentation: Map the Act Names to the Transformer

Open juvogt opened this issue 1 year ago • 3 comments

Proposal

Create a figure that maps the act names to the transformer architecture.

Motivation

Names are just conventions. I find it hard to get the exact position within the transformer block just from the act name. I.e. the resid_pre might be before the split happens or before the merge happens. So I put it in context to the other act names and work by exclusion process or modify it to see what values will change.

Pitch

I suggest using the images from the Vasvani paper and adding labeled arrows pointing to the hook positions.

Alternatives

A list or table of (act name, description) pairs.

Checklist

  • [x] I have checked that there is no similar issue in the repo (required)

juvogt avatar Jun 21 '24 08:06 juvogt

@JuVogt Do you have time to handle this issue?

bryce13950 avatar Jun 26 '24 00:06 bryce13950

I could put together something this week as a first PR for this project

tjbai avatar Jul 23 '24 05:07 tjbai

I am willing to contribute as well, but I am currently out of time, sorry for that. I can come back after I finish my thesis at the end of the year and design something, but a first sketch would definitely help. Maybe I could then add a list with the act names including some more information about i.e. the dimensions and calculations behind it if someone already contributed a sketch or vice versa.

Also, I could add some more documentation with minimal examples beside the colabs that I think would help me in the beginning.

juvogt avatar Jul 30 '24 09:07 juvogt