Easy-Transformer icon indicating copy to clipboard operation
Easy-Transformer copied to clipboard

add optional arguments to make sure generate() works without tokenizer being defined

Open JackCai1206 opened this issue 1 year ago • 1 comments

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #483

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] I have not rewritten tests relating to key interfaces which would affect backward compatibility

JackCai1206 avatar Jan 22 '24 15:01 JackCai1206

@JackCai1206 Do you have a moment to pop in and resolve these errors https://github.com/neelnanda-io/TransformerLens/actions/runs/8654322622/job/23731321640?pr=488?

bryce13950 avatar Apr 11 '24 23:04 bryce13950