Easy-Transformer icon indicating copy to clipboard operation
Easy-Transformer copied to clipboard

[Bug fix] GatedMLP not in docs. issue #264 [bug report]

Open danlaudk opened this issue 1 year ago • 1 comments

I am using the linked issue and this PR as a way to upskill into ai safety, as my first contribution

Currently draft. PR to come this week

Feedback sought: is editing this unit test sufficient in terms of testing? Did you have something else in mind? (like testing the actual math) Any comments would help me get acquainted with the library.

Based on my current unchecked understanding, I decided against creating a new test. And within that considered but decided against having a test with both gated=True and gated=False options and a comparison for not-equals.

Description

  • edit test
  • update docstring

am not doing the issue's Optional part as it's beyond my understanding.

Fixes #264

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] I have not rewritten tests relating to key interfaces which would affect backward compatibility

danlaudk avatar Nov 14 '23 13:11 danlaudk

@danlaudk Sorry for the delay on this. Are you still interested in solving this issue? I would be very happy to help you resolve it if you still have the time.

bryce13950 avatar Apr 27 '24 18:04 bryce13950