Neel Doshi

Results 84 comments of Neel Doshi

> I am making this PR as draft for now. As I have many PR in queue once its ready for review I will open it again. The PR is...

> Tests are failing Hi @david-allison. The test is getting failed because in CustomStudyDialogTest we have used MaterialDialog so when testing it with AlertDialog its getting failed i guess. [CustomStudyDialogTest](https://github.com/ankidroid/Anki-Android/blob/0ab90ba8c1def105b512b507800c823d85bc9af4/AnkiDroid/src/test/java/com/ichi2/anki/dialogs/CustomStudyDialogTest.kt#L21)...

Test case passed!!! Special thanks to David for the patch that fixed the testcase.

Hi, should I squash down to two commits now - Refactor to Alert Dialog - Listitem code refactor or should I squash down to one commit?

Squashed the commits. Did a git checkout for https://github.com/ankidroid/Anki-Android/pull/15459/commits/b48180b3a861e6e7988654d03d844f0b7ad064a6 and it compiles.

@lukstbit should I remove this redundant package as this is no longer used in our test after `CustomStudyDialog` migration? https://github.com/ankidroid/Anki-Android/blob/6354574aee656b96f732928007618286e9e6c239/AnkiDroid/src/test/java/com/ichi2/testutils/DialogUtils.kt#L17-L37

> Split out the 'easy' dialog into another PR > > Fixing the second dialog will take longer. Padding definitely needs to be fixed Also what about the divider decoration?

**Edit :** I fixed it. **Edit:** Updated the PR description and added the commit. @david-allison ~~I have not tested it yet but I am thinking what if I create an...

> The vertical padding on that screenshot looks off, and the touch targets look too small > > Try adding 8-12dp top & bottom and see if it looks good...

> @neeldoshii Check the patch below for specific changes. Note that I didn't verify the dialog on the emulator. > > ```diff > diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/CardBrowserMySearchesDialog.kt b/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/CardBrowserMySearchesDialog.kt > index b068b3d804..78bd03204c...