Neel Gupta

> As I said [#119 (comment)](https://github.com/optuna/optuna-integration/pull/119#discussion_r1605935768), the current change does not store any data, which is not what we expect. Could you discard values only when `values` is None implemented...

I changed the syntax slightly to be more pythonic and override `metrics` if `values is not None` and fixed the tests. Should I add some more checks in the tests?...

> I'm not sure Callable is a good type annotation, but at least mypy looks happy. Narrator: mypy was in fact not happy :wink:

@nzw0301 How does it look?

@jakevdp With all due respect, GH discussions are too fragmented and not really well searchable - nor do they encourage interesting discussions and ideas. I think going forward, a discord...

I put it under the `[language-server.basedpyright.config]` as ```py python.venvPath = "/Users/me/miniconda3/envs/react_jax" ``` still doesn't work. > the language server specific options are documented [here](https://docs.basedpyright.com/#/settings). not sure why some settings are...

No thats the directory to a conda environment, so it doesn't have a `.venv` there. And it doesn't make sense to use the toml/json files as I want this setting...

Cool, but what about `basedpyright`'s own config settings? like changing `reportPrivateImportUsage = false` which is not a pyright config 🤔

right so uh, that doesn't work at *all* for me...  where in my `languages.toml` for `helix`, ```toml [language-server.basedpyright.config] basedpyright.analysis.typeCheckingMode = "standard" ... basedpyright.reportPrivateUsage = false ``` I've tried variants...

> also, which version of basedpyright are you using? The latest - I installed it yesterday from homebrew. > if that still doesn't help, i might need a self-contained repro...