NewRelic icon indicating copy to clipboard operation
NewRelic copied to clipboard

Published 20 hours ago • verified publisher icon neeckeloo

add unit tests to cover module, request factory, and response factory.

Open abacaphiliac opened this issue 8 years ago • 10 comments

  • add unit tests to cover module, request factory, and response factory.
  • update module doc-block.

abacaphiliac avatar Dec 15 '16 15:12 abacaphiliac

Coverage Status

Coverage increased (+13.3%) to 73.485% when pulling 2a36ca59717d7ca2c576748dda21754fe9391f5e on abacaphiliac:add-tests into 70ed596c9b326c0cf9c0cd24221e93e9836b4f46 on neeckeloo:master.

coveralls avatar Dec 15 '16 15:12 coveralls

Coverage Status

Coverage increased (+13.3%) to 73.485% when pulling 2a36ca59717d7ca2c576748dda21754fe9391f5e on abacaphiliac:add-tests into 70ed596c9b326c0cf9c0cd24221e93e9836b4f46 on neeckeloo:master.

coveralls avatar Dec 15 '16 15:12 coveralls

Coverage Status

Coverage increased (+13.3%) to 73.485% when pulling 2a36ca59717d7ca2c576748dda21754fe9391f5e on abacaphiliac:add-tests into 70ed596c9b326c0cf9c0cd24221e93e9836b4f46 on neeckeloo:master.

coveralls avatar Dec 15 '16 15:12 coveralls

Coverage Status

Coverage increased (+13.3%) to 73.485% when pulling 2a36ca59717d7ca2c576748dda21754fe9391f5e on abacaphiliac:add-tests into 70ed596c9b326c0cf9c0cd24221e93e9836b4f46 on neeckeloo:master.

coveralls avatar Dec 15 '16 15:12 coveralls

ouch. the --prefer-lowest builds bit me ; )

abacaphiliac avatar Dec 15 '16 15:12 abacaphiliac

Coverage Status

Coverage increased (+13.3%) to 73.485% when pulling 9c49623e47882ff2f80b1a021ca3b6585d22409b on abacaphiliac:add-tests into 70ed596c9b326c0cf9c0cd24221e93e9836b4f46 on neeckeloo:master.

coveralls avatar Dec 15 '16 16:12 coveralls

Coverage Status

Coverage increased (+13.3%) to 73.485% when pulling 9c49623e47882ff2f80b1a021ca3b6585d22409b on abacaphiliac:add-tests into 70ed596c9b326c0cf9c0cd24221e93e9836b4f46 on neeckeloo:master.

coveralls avatar Dec 15 '16 16:12 coveralls

Coverage Status

Coverage increased (+13.3%) to 73.485% when pulling 9c49623e47882ff2f80b1a021ca3b6585d22409b on abacaphiliac:add-tests into 70ed596c9b326c0cf9c0cd24221e93e9836b4f46 on neeckeloo:master.

coveralls avatar Dec 15 '16 16:12 coveralls

Coverage Status

Coverage increased (+13.3%) to 73.485% when pulling 9c49623e47882ff2f80b1a021ca3b6585d22409b on abacaphiliac:add-tests into 70ed596c9b326c0cf9c0cd24221e93e9836b4f46 on neeckeloo:master.

coveralls avatar Dec 15 '16 16:12 coveralls

@neeckeloo ok, got the --prefer-lowest tests to pass. i was trying to cheat and use a real Application instance instead of mocking the interface and those instances are different between ZF2 and ZF3. who would've thought? : P

are you interested in only sending coverage to coveralls for a single build? and if so, which one?

abacaphiliac avatar Dec 15 '16 16:12 abacaphiliac