firefox-gmail-manager-ng icon indicating copy to clipboard operation
firefox-gmail-manager-ng copied to clipboard

Never works with Firefox 32 +

Open Endor8 opened this issue 10 years ago • 48 comments

Hi. Gmail Manager never works with Firefox 32 or higher. With Firefox 32 it is necessary to use the new cache-backend. Actually it is never possible to store accounts or the Position of the Toolbarbutton. Please try to fix this. Gmail Manager is the best Manager for Gmail accounts. Thanks Endor

Endor8 avatar Jul 31 '14 18:07 Endor8

I agree. This addon appears to be broken on Firefox 32.0.

kzalewski avatar Sep 02 '14 21:09 kzalewski

GMail Mananger NG has worked up until FF 32.0 came out the other day. Please please fix this! You forked the best addon in the history of all addons! Keep it going we need you! THANKS!

garlicgmailmanager avatar Sep 03 '14 05:09 garlicgmailmanager

The problem seems to come from this: https://developer.mozilla.org/en-US/docs/Xray_vision#Waiving_Xray_vision

it's a protection mechanism to forbid data transmission between the "front-end" of the plugin (in chrome/gmanager.jar) and the backend of the plugin (components). It's new to FF 32 for js arrays.

I tried to modify the files in gmanager.jar with additional Components.utils.waiveXrays(), but it still doesn't work...

damienfournier avatar Sep 04 '14 12:09 damienfournier

I read it as it needs putting in the javascript rather than in the main java code...

StephenAtty avatar Sep 04 '14 17:09 StephenAtty

Any help on where/how to debug this problem welcome! :) I tried to find out, but no real clue yet.

What are the breaking changes between FF 31 and 32 that affect us, and where are they used in source files? You talked about "new cache-backend", and "Xray vision"...

Addon log in console does not show significant errors for me. Facts as I observed are:

  • prefs.xml storing accounts seems not to be read/retrieved properly as related panel in Options window is empty
  • account creation works partly: account added in panel when created from Options window, but panel still empty when window is closed and reopened, and same if account is created from elsewhere and window open then ; account is stored fully in prefs.xml file as expected
  • mails fetched from Gmail after Connect account > no account = create it > save ; but inside toolbar loading icon never stops / open a new FF window, and there, loading icon is not present, replaced by standard blue Gmail icon
  • addon position in toolbar seems not to be "persisted" as opening a new window makes it be restored to FF Customize panel for both windows
  • closing FF and reopening it reset all

ath0mas avatar Sep 05 '14 08:09 ath0mas

I don't think the problem comes from the new cache-backend, because the deprecated functions for the old cache aren't used in gmail manager.

For me, it's about the xray vision. From what I understood, the gui is in the front-end of the plugin, in the jar file. Xray vision means that the front end can't access data from the backend (in components). That's why the gui can't get the account list from the backend at startup, and the backend can't save account data & prefs from the gui (it deletes everything because it has no data). See the link that I gave for more information.

damienfournier avatar Sep 05 '14 09:09 damienfournier

I understood well what your link describes. Indeed, those other links mention Xray vision too and I agree it seems to be the only change that can interest us:

For now I'll try to dig into source to have a more precise match - any help still welcome ;) (1 week away from keyboard for now)

ath0mas avatar Sep 05 '14 09:09 ath0mas

Someone seems to have succeeded there: http://forums.mozillazine.org/viewtopic.php?f=48&t=332634&sid=ab76afa9ab02e6d427618483800b7de7&start=4680 (last post on that page)

damienfournier avatar Sep 05 '14 21:09 damienfournier

whow :muscle: you rock and Odilatinam too!! I start "Working" on building a new branch with fixed XPI now And in a week, I'll merge back old fixes and changes inherited from existing forks of this repo. We'll try to make this addon alive again then :)

ath0mas avatar Sep 05 '14 22:09 ath0mas

Here it is: 0.6.5.3 + my project additions + Odilatinam FF32 fix + twang817 Google domains fix = https://github.com/ath0mas/firefox-gmail-manager-ng/blob/develop/dist/gmail_manager_ng-0.6.5.3-fixFF32.xpi

:e-mail: direct raw download: https://github.com/ath0mas/firefox-gmail-manager-ng/raw/develop/dist/gmail_manager_ng-0.6.5.3-fixFF32.xpi

see my develop branch

ath0mas avatar Sep 05 '14 23:09 ath0mas

this is great ath0mas, but I am a noob and how can i know to trust this? Was it sent to Firefox for at least eh security check? Should I, as a noob, just assume this is safe and install it? Why wouldn't it send my login credentials to a third party?

garlicgmailmanager avatar Sep 06 '14 04:09 garlicgmailmanager

You are fully right, unknown sources should never be trusted. Except that here, complete sources are available in this repo and changes made are listed in my branch. Then, XPI was generated for easier download and use ; you can easily rebuild it from sources, from my branch, running makefile, or shell script present.

ath0mas avatar Sep 06 '14 10:09 ath0mas

@ath0mas tu reprends la gestion du plugin ? (en le remettant sur le site officiel firefox aussi ?)

damienfournier avatar Sep 06 '14 16:09 damienfournier

@damienfournier ça me tente bien oui, si les gens veulent que je m'en occupe et que la communauté de ce module pousse pour que ça reparte. Niveau Mozilla et même GitHub je suis coincé car je n'ai trouvé aucun moyen de contacter @nedwidek ... Je suis off une semaine, tu pourrais chercher de ton côté stp ? Sinon j'envisage nouveau nom de module, nouveau repo GitHub officiel, communauté GitHub pour s'en occuper, pour éviter le syndrome 1 personne qui disparaît et qui bloque tout.

ath0mas avatar Sep 06 '14 22:09 ath0mas

@ath0mas thank you for the reply ath0mas . have you considered forking this yet again and submitting it to Mozilla?

garlicgmailmanager avatar Sep 07 '14 00:09 garlicgmailmanager

@garlicgmailmanager that's what we were talking about in french, so I continue in english

@ath0mas I've found nedwidek business contact on his website: http://hatterassoftware.com/pages/contact

I think the possibilities are:

nedwidek continues being the manager of the plugin and update the plugin

nedwidek can't continue but agrees to transfer the project to a community repository, you take over as the manager

nedwidek doesn't answer or agree, then you fork the project with a new name and a new entry in the firefox plugin repository

For me, I'm not skilled enough in firefox plugin development to add features, but I can help with website, documentation & tutorials

damienfournier avatar Sep 07 '14 09:09 damienfournier

I hate to be the party breaker but I found some bugs...

gm_account1_bug1 On this screen you can see that I have several unread messages on my first account gm_account1_bug2 And you can also this on the popup over the plugin icon that the unread messages number is wrong and that the account size is also wrong (like if nothing was read from the account) There's also a bug line "gmanager-toolbar-tooltip-important-unread" To be clear, I have checked the 3 options to check for unread messages in the main box, the spam folder and the labels

Here's a screenshot from my second account : gm_account2_bug1 I have one unread message from the main box Here is the popup : gm_account2_bug2 The icon is blue and the unread number is accurate (as the spam number) There's still the bug line "gmanager-toolbar-tooltip-important-unread" though About the account size, I can't check if it's accurate, since this email account is kinda empty, Gmail at the bottom of the page states "0.06 GB (0%) of 15 GB used". So I guess it's logical.

The password from the first account is correct because when I try to input a wrong one, when the plugin tries to check, I've got the popup saying that the password is wrong. When the original plugin broke when upgrading to FF32, I tried several other forks from the original plugin. Do you think it could have messed the internal config ? (the lines we find in the about:config screen)

Also, an other "bug" (or perhaps an feature not implemented from the main plugin), when I middle-click, it only checks the currently selected account and not all of them

If you need any tests or log or whatever to verify some things, I'd be happy to help

MickBim avatar Sep 07 '14 10:09 MickBim

I also have one account that displays 0 mail in inbox, the others 6 accounts are ok. "Space used" is wrong for all

damienfournier avatar Sep 07 '14 10:09 damienfournier

First of all thank you for the fixes, at least it works again. (but...) Few bugs appeared since the latest fix for ff32.

  • gmanager-toolbar-tooltip-important-unread? this is what the toolbar tip shows, i do not know why ()
  • I can't set the time interval to check for new mails and after I log in to gmail, does not disappeare the blue notification icon, does not turn into red. Still shows the new mails, altough I read them.
  • still *"almost" deleting the account, but it is still there somewhere in the background, tool tip comes up and shows new mails. wierd strange behavior. Sometimes it is disappeare from the "The addon bar". I use "The addon bar" extension since firefox removed the lower status bar.

FF32 / using one gmail account.

gmng avatar Sep 08 '14 15:09 gmng

Thanks for the fix! Anyway to fix preference import function? I backed up my prefs just before FF32, and it wouldn't let me import them back into the fixed gmail manager.

Dixon12 avatar Sep 09 '14 09:09 Dixon12

@ath0mas Mille mercis Oui, reprends le comme indiqué à Damien. Ce plugin est excellent et a le mérite - lui - de ne pas retenir les mots de passe.

vin100vin avatar Sep 09 '14 12:09 vin100vin

Even with the so called "fix", I'm still having trouble with this add-on. It doesn't remember the settings.

hookback avatar Sep 09 '14 15:09 hookback

the pop up slices for the gmail social, promotional etc. tabs does not work. I can't believe that thousands of people using this extension, but there isn't even one coder to fix the code. Come on guys, nice challenge :+1:

gmng avatar Sep 12 '14 10:09 gmng

0.6.5.3 was working but from today it's not working anymore with Google Apps accounts . It's freezing FF

vin100vin avatar Sep 12 '14 13:09 vin100vin

I can confirm too, 0.6.5.3 was working but now it also freezes my firefox version 32. I cant even disable plugin, i have to go to safe mode to disable it :(

svecka avatar Sep 15 '14 00:09 svecka

Same here (like vin100vin & svecka). The gmail account for which the fixed plugin wasn't working is now freezing FF32.0.1 When I try only with the one account that worked all the time, not a single crash Very strange... and also a pain in the ass since the "bugged" gmail account is my main one

MickBim avatar Sep 16 '14 20:09 MickBim

FF32.0.1 + 0.6.5.3 > also freezing with the second account in the list...

jpwall5 avatar Sep 17 '14 17:09 jpwall5

Same here... fix was working, now it freezes firefox at startup, I had to disable the addon in safe mode...

damienfournier avatar Sep 18 '14 08:09 damienfournier

It's a bit of a shame, but i've decided to install Firefox ESR just to maintain compatibility with this add-on. https://www.mozilla.org/en-US/firefox/organizations/all/

@ath0mas - thank you for the fix; it worked until the last update. i looked at all the code, and jeez it's a lot of stuff i don't understand, but i'd love to strip-out so much and make it an multi-icon/sound only notifier and remove all the preview, pop-up, compose, etc. Would you be interested in doing that?

meoso avatar Sep 19 '14 13:09 meoso

I am running FF32.0.2 + 0.6.5.3, with 5 GMail account all of them work ok except 1, the only one i have Google+ profile, and the one i have more Lables. I also notice the account that freezes gives my cpu a load spike.

Can you guys check if the account(s) that freezes also have or not Google+ profile? Can the 'aNode.ownerDocument' be messing up things?

jpwall5 avatar Sep 19 '14 14:09 jpwall5