Julius

Results 16 comments of Julius

hey, just wanted to inform interested parties that I am still looking into this issue. just didn't have much time to invest lately.

alright, I started working on this issue. before I make any further strides, I would like you to evaluate some of the assumptions that I am currently making: - we...

what would be the sorting for spread styles? say we have something like this: ```tsx const reusableStyles = { display: 'flex' } const styles = stylex.create({ foo: { position: 'relative',...

hi @glasser, I am a new contributor and I would be happy to work on this issue. would I add this test to the general `apolloServerTests.ts` suite?

should this be removed from the plugin? https://github.com/facebook/stylex/blob/bea3495859da52fa1d581df409b1dac8f7e4e934/packages/eslint-plugin/src/stylex-valid-styles.js#L2481 there is a `TODO` comment that reminds to remove this suggestion as well

> The ESLint rule seems to already support any string as we have: [`const color = makeUnionRule(isString, isNamedColor, isHexColor)`](https://github.com/facebook/stylex/blob/main/packages/eslint-plugin/src/stylex-valid-styles.js#L151). Plus, I'm not getting any error with the given example with...