formatting-stack icon indicating copy to clipboard operation
formatting-stack copied to clipboard

formatting-stack.processors.test-runner/test!: return a useful value

Open vemv opened this issue 4 years ago • 2 comments

Context

test! currently returns the fixed value nil. This makes it a limited primitive for creating more substantial functionality.

Task

Make it return a boolean depending on whether the test suite passed

Acceptance criteria

A boolean? is returned no matter what, even in face of exceptions (as they are common in WIP/failing/flaky tests)

vemv avatar Mar 15 '21 07:03 vemv

Using a boolean now prevents expansion in the future.

What do you think about returning a map? It can yield :result? now, and possibly reports or tested-files in a later iteration.

thumbnail avatar Mar 15 '21 10:03 thumbnail

Yeah returning the same map that clojure.test does seems best 👍

vemv avatar Mar 15 '21 10:03 vemv