Niall Douglas comments

Results 195 comments of


                                            Niall Douglas

Unfound includes passed through despite NO `--passthru-unfound-includes`

Cool

LL suffix not parsed correctly

We ought to do a better job in pcpp parsing U, L, LL, ULL etc. Thanks for the BR.

## with empty macro argument is wrong.

Thanks for the BR

#include "..." parses the file name incorrectly. It is not a string literal.

Seems reasonable.

Drop Python 2.7 compatibility?

I hope to make the next major release of pcpp around this time next year i.e. start of 2025 if that's any use. Until then, I simply do not have...

Basic tox with pyenv setup for testing

Thanks for the PR. Doesn't tox also support windows?

Basic tox with pyenv setup for testing

Will you promise to me that if I merge this now that you **will** contribute tox support for windows?

Basic tox with pyenv setup for testing

Thanks for the honesty! I'm going to reopen this PR however, as roughly once per year I try to close all open bug count, merge all open PRs and do...

#include guard containing whitespace is not detected.

Thanks for the BR!

Project does not build with clang, and does not link with GCC 10

Good to hear about the second and third issues being fixed. I'll pass that on to the others. For the first issue, it's a widespread problem best illustrated using https://godbolt.org/z/q65nxG...