react-native-web icon indicating copy to clipboard operation
react-native-web copied to clipboard

fix: measureLayout relative to ScrollView returns incorrect y value

Open shubham1206agra opened this issue 2 years ago • 3 comments

Trying to fix #2109

I will put details once I confirm this works perfectly.

shubham1206agra avatar Aug 10 '23 17:08 shubham1206agra

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2d5f2a3fa64fccdc905b3f34660df1d81c364b1b:

Sandbox Source
react-native-web-examples Configuration
Issue: React Native for Web Issue #2109
morning-rgb-3wc533 Issue #2109

codesandbox-ci[bot] avatar Aug 10 '23 17:08 codesandbox-ci[bot]

@necolas I think it's working fine. https://codesandbox.io/s/issue-react-native-for-web-forked-9zytqk?file=/src/App.js Can you confirm the same?

shubham1206agra avatar Aug 10 '23 17:08 shubham1206agra

I think it's working fine

The existing unit tests fail. PR needs to pass unit tests and add new tests for the issue that 1) fail on master, 2) pass with this patch.

necolas avatar Aug 24 '23 19:08 necolas