auto-request-review icon indicating copy to clipboard operation
auto-request-review copied to clipboard

auto-request-review doesn't add reviewers from github team.

Open lurbanski-equinix opened this issue 3 years ago • 6 comments

Hi, Normal configuration with list of reviewer works. Thanks a lot. It is very useful action.

I have an issue with using github team. The action doesn't add reviewers from a github team.

Logs:

with:
    token: ***
    config: .github/config/reviewers.yaml
Fetching configuration file from the source branch
Fetching changed files in the pull request
Identifying reviewers based on the changed files
A "files" key does not exist in config; returning no reviewers for changed files.
Identifying reviewers based on the author
Adding other group members to reviewers if group assignment feature is on
Group assignment feature is enabled
Randomly picking reviewers if the number of reviewers is set
Requesting review to team:my-team

Configuration:

- name: Auto request review
   uses: necojackarc/auto-request-review@91e252d75fe335f586be7e243c39e5dd88f2e153
   with:
      token: ${{ secrets.GIT_PAT }}
      config: .github/config/reviewers.yaml

reviewers.yaml

reviewers:
  per_author:
    lurbanski-equinix:
      - team:my-team

options:
  ignore_draft: false
  enable_group_assignment: true

I also tried to set "Enable auto assignment" in the team settings, but it doesn't work as well. My GIT_PAT has full access to repo.

lurbanski-equinix avatar Jan 10 '22 11:01 lurbanski-equinix

Hi, thank you for you bug report and sorry for the late reply! I've been struggling to find spare time, but I'll try to have a look!

necojackarc avatar Jan 21 '22 00:01 necojackarc

@necojackarc no problem.

lurbanski-equinix avatar Jan 21 '22 08:01 lurbanski-equinix

I gently remind about the issue.

lurbanski-equinix avatar Mar 22 '22 15:03 lurbanski-equinix

@lurbanski-equinix I just set this up for my own team, I wonder if you need the files key as well? Something like

files:
  '**':
    - team:my-team 

rafistrauss avatar Mar 22 '22 20:03 rafistrauss

Thanks rafistrauss. Nice workaround, but I need different reviewers depend on commit authors.

lurbanski-equinix avatar May 12 '22 08:05 lurbanski-equinix

Also using this configuration should be accessible.

reviewers:
  per_author:
     team:my-team:
      - team:my-team

lurbanski-equinix avatar May 12 '22 08:05 lurbanski-equinix

Bump on this

hbrysiewicz avatar May 01 '23 16:05 hbrysiewicz

#88 has added support for the following configuration:

reviewers:
  per_author:
    team:koopa-troop:
      - mario

Many thanks to @hbrysiewicz

necojackarc avatar May 23 '23 16:05 necojackarc