timeline_editor icon indicating copy to clipboard operation
timeline_editor copied to clipboard

Customizable TimelineEditorTrack action icons

Open argorain opened this issue 5 years ago • 3 comments

Hi!

I see there is lot of new stuff in master (thank you!) and one of them are action icons for dragging, scaling and menu. Frankly, it took me just too long to figure it out. It's due drag action icon is same as scale action icon. I couldn't find how to drag box and had to debug it to see what I am doing wrong. Maybe just replacing it with https://material.io/resources/icons/?search=drag&icon=drag_indicator&style=baseline would be enough.

See it before and after

I think there should be some way how to modify those icons to match general app look and feel and right now there is only way modify plugin sources directly. If you decide not to give users this level of control, then we should at least fix those icons.

Thank you and keep up doing great job!

Vojtech

P.S. I can do those modifications and submit PR if we agree to do them.

argorain avatar Dec 10 '20 11:12 argorain

As I am digging more and more int this, I am now convinced that icons must be configurable. User can do anything in those callbacks.

argorain avatar Dec 11 '20 08:12 argorain

Thanks very much for your contribution. I release a first preview version with your dev included: https://pub.dev/packages/timeline_editor/versions/0.4.0-preview.1 There was a lot of rewrite so i need more time to test. Unfortunately since COVID i have very little :(

neckaros avatar Dec 19 '20 22:12 neckaros

No problem mate, it's tough time for everyone. Thanks for releasing preview version :)

argorain avatar Dec 20 '20 10:12 argorain