neb.js icon indicating copy to clipboard operation
neb.js copied to clipboard

The gulp incompatible node v10.0.0

Open act262 opened this issue 6 years ago • 4 comments

Environment: neb.js git:(master) ✗ node -v v10.0.0

gulp run abort: gulp gulp[84896]: ../src/node_contextify.cc:631:static void node::contextify::ContextifyScript::New(const FunctionCallbackInfo<v8::Value> &): Assertionargs[1]->IsString()' failed. 1: node::Abort() [/usr/local/bin/node] 2: node::Assert(char const* const () [4]) [/usr/local/bin/node] 3: node::contextify::ContextifyScript::New(v8::FunctionCallbackInfov8::Value const&) [/usr/local/bin/node] 4: v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo) [/usr/local/bin/node] 5: v8::internal::MaybeHandlev8::internal::Object v8::internal::(anonymous namespace)::HandleApiCallHelper(v8::internal::Isolate*, v8::internal::Handlev8::internal::HeapObject, v8::internal::Handlev8::internal::HeapObject, v8::internal::Handlev8::internal::FunctionTemplateInfo, v8::internal::Handlev8::internal::Object, v8::internal::BuiltinArguments) [/usr/local/bin/node] 6: v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/usr/local/bin/node] 7: 0x18b90a18427d 8: 0x18b90a18f755 9: 0x18b90a20bc20 10: 0x18b90a1944f7 11: 0x18b90a1944f7 12: 0x18b90a1944f7 [1] 84896 abort gulp `

Maybe official release final dist js for us ,so we don't need to build it ourself.

act262 avatar May 02 '18 00:05 act262

Hello @act262 , Thanks for your information, we are looking into the issue, stay tuned :)

ChengOrangeJu avatar May 03 '18 04:05 ChengOrangeJu

Hello @act262 , Discussed with team members that dist js might not be suitable to be included in the project for the reason that it could change quite often between different commits.

ChengOrangeJu avatar May 03 '18 05:05 ChengOrangeJu

You could publish a separate npm package containing just the build code, then users could just npm install and use that directly

marcusjrc avatar May 03 '18 12:05 marcusjrc

just switch to node 8 and gulp would work ( I use n command switch to node version 8)

1c7 avatar Jan 18 '19 09:01 1c7