nebula icon indicating copy to clipboard operation
nebula copied to clipboard

indexQuery method includes softDeleted models.

Open gregorip02 opened this issue 4 years ago • 4 comments

It is a good idea to exclude global scopes to increase query performance, but there is a problem when models are softDeleted because they keep showing up in the indexQuery.

We can solve it by overwriting this method in our resource, but it should ignore the softDeleted models by default.

gregorip02 avatar Sep 29 '20 14:09 gregorip02

I'm not a fan of soft deletes but I guess we could support this

Larsklopstra avatar Sep 29 '20 16:09 Larsklopstra

Perhaps a more flexible filter with "Includes trashed"

Larsklopstra avatar Sep 29 '20 16:09 Larsklopstra

Perhaps a more flexible filter with "Includes trashed"

I'd go down this route of providing a filter for including trashed / deleted items.

ryangjchandler avatar Sep 29 '20 16:09 ryangjchandler

Perhaps a more flexible filter with "Includes trashed"

Awesome, this will work.

gregorip02 avatar Sep 29 '20 16:09 gregorip02