nebula-release-plugin icon indicating copy to clipboard operation
nebula-release-plugin copied to clipboard

Ordering of tasks can be wrong

Open carstenlenz opened this issue 7 years ago • 1 comments

Hey. I just tried out the 5.0.0 lifecycle feature and noticed that despite the description that the release task depends on the specific xxxSetup task it does not. The ordering is determined by the task ordering logic of Gradle when there are no rules or dependencies (which is alphabetically I think).

So the feature works for e.g. with candidate, final, devSnapshot where the ordering is right but does not work with snapshot.

Output in my sample:

$> gradle snapshot -m

Inferred project: myproject, version: 2.0.0-SNAPSHOT
:prepare SKIPPED
:release SKIPPED
:compileJava SKIPPED
:compileGroovy SKIPPED
:generateResources SKIPPED
:pluginDescriptors SKIPPED
:processResources SKIPPED
:classes SKIPPED
:jar SKIPPED
:groovydoc SKIPPED
:publishPluginGroovyDocsJar SKIPPED
:publishPluginJar SKIPPED
:javadoc SKIPPED
:publishPluginJavaDocsJar SKIPPED
:publishPlugins SKIPPED
:postRelease SKIPPED
:releaseCheck SKIPPED
:snapshotSetup SKIPPED
:snapshot SKIPPED

My expectation would be that snapshotSetup and releaseCheck would always run before release.

carstenlenz avatar May 10 '17 09:05 carstenlenz

Thanks for the report will add some tests and release a patch if fixed On Wed, May 10, 2017 at 2:58 AM Carsten [email protected] wrote:

Hey. I just tried out the 5.0.0 lifecycle feature and noticed that despite the description that the release task depends on the specific xxxSetup task it does not. The ordering is determined by the task ordering logic of Gradle when there are no rules or dependencies (which is alphabetically I think).

So the feature works for e.g. with candidate, final, devSnapshot where the ordering is right but does not work with snapshot.

Output in my sample:

$> gradle snapshot -m

Inferred project: myproject, version: 2.0.0-SNAPSHOT :prepare SKIPPED :release SKIPPED :j:compileJava SKIPPED :compileGroovy SKIPPED :generateResources SKIPPED :pluginDescriptors SKIPPED :processResources SKIPPED :classes SKIPPED :jar SKIPPED :groovydoc SKIPPED :publishPluginGroovyDocsJar SKIPPED :publishPluginJar SKIPPED :javadoc SKIPPED :publishPluginJavaDocsJar SKIPPED :publishPlugins SKIPPED :postRelease SKIPPED :releaseCheck SKIPPED :snapshotSetup SKIPPED :snapshot SKIPPED

My expectation would be that snapshotSetup and releaseCheck would always run before release.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nebula-plugins/nebula-release-plugin/issues/81, or mute the thread https://github.com/notifications/unsubscribe-auth/AAvvFo5GRJYOVpyc4crXPjonQNak8Oouks5r4YozgaJpZM4NWb7A .

rspieldenner avatar May 10 '17 15:05 rspieldenner