nebula-release-plugin icon indicating copy to clipboard operation
nebula-release-plugin copied to clipboard

check if version provided from command line is not in conflict to intended stage

Open marmax opened this issue 8 years ago • 2 comments

I was (unfortunately) able to invoke the following command: ./gradlew clean snapshot -Prelease.version="2.7.1" which led to tagging my repo with sort of 'final' version tag despite the fact that the stage was 'snapshot' (as defined by the task 'snapshot')

I think this behaviour is incorrect - the plugin should either check for/append "-SNAPSHOT" to the version or better throw an exception with appropriate explanation.

marmax avatar Jun 01 '16 16:06 marmax

Agreed, will add it to the TODOs

On Wed, Jun 1, 2016 at 9:37 AM Marian Stránecký [email protected] wrote:

I was (unfortunately) able to invoke the following command: ./gradlew clean snapshot -Prelease.version="2.7.1" which led to tagging my repo with sort of 'final' version tag despite the fact that the stage was 'snapshot' (as defined by the task 'snapshot')

I think this behaviour is incorrect - the plugin should either check for/append "-SNAPSHOT" to the version or better throw an exception with appropriate explanation.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nebula-plugins/nebula-release-plugin/issues/51, or mute the thread https://github.com/notifications/unsubscribe/AAvvFhI79aNGDZtPwGKHd8C2c1kWXe6Mks5qHbVYgaJpZM4IrvlI .

rspieldenner avatar Jun 01 '16 17:06 rspieldenner

+1 vote. This would be a really nice feature. Until it got implemented at least the documentation should be updated and cover this case.

foldvari avatar Sep 25 '20 15:09 foldvari