nebula-release-plugin icon indicating copy to clipboard operation
nebula-release-plugin copied to clipboard

Bug forcing tag naming strategy with prefix v

Open bueno-felipe opened this issue 5 months ago • 3 comments

From version 18.0.6 and so on the NearestVersionLocator only read tags that use v as prefix, as you can see in this commit: https://github.com/nebula-plugins/nebula-release-plugin/commit/7d369f630fd937d7069e5c50857089e052ebf1e4

https://github.com/nebula-plugins/nebula-release-plugin/blame/c3850c0a954fafce9064c94ad1c47a58f94381fd/src/main/groovy/nebula/plugin/release/git/command/GitReadCommand.groovy#L115

But the base plugin gradle-git allow users to extend the tagStrategy to define how the git tag will be created, through setting:

#build.gradle
release {
    tagStrategy {
       prefixNameWithV = false
    }
}

or

#build.gradle
release {
    tagStrategy {
       toTagString = { version -> "${version}" }
    }  
}

Shouldn't it to be consider as a bug?

bueno-felipe avatar Sep 12 '24 15:09 bueno-felipe