gradle-ospackage-plugin icon indicating copy to clipboard operation
gradle-ospackage-plugin copied to clipboard

Added property osname to support AIX rpm.

Open pradeepbansal00 opened this issue 5 years ago • 5 comments

This is simply the porting of change which Brian Cox did on v3.2.1 version ( https://github.com/nebula-plugins/gradle-ospackage-plugin/compare/master...brc0x1:feature/osname?expand=1)

pradeepbansal00 avatar Apr 29 '19 18:04 pradeepbansal00

Coverage Status

Coverage decreased (-0.1%) to 85.388% when pulling b78f71f14ab88fdabcc217b5d4627861d5b2b7d0 on pradeepbansal00:v3.6.1 into 1bd99618cb601886ae506dae00129ed06f7287d9 on nebula-plugins:master.

coveralls avatar Apr 29 '19 19:04 coveralls

Looks good, thanks @pradeepbansal00.

aaltman avatar Apr 29 '19 19:04 aaltman

Is there any way this can be merged ?

mnellemann avatar May 11 '21 16:05 mnellemann

Thank you for the contribution. Could you rebase the PR?

chali avatar May 19 '21 22:05 chali

It looks like a lot of changes has been been made since this PR.

I have done some testing (id "nebula.ospackage" version "8.5.6") and tried to build an rpm for AIX with the following task in my build.gradle:

task buildRpmAix(type: Rpm) {
    dependsOn build, startShadowScripts
    packageName = 'jload-AIX'
    os = Os.AIX
    arch = Architecture.NOARCH
    type = RpmType.BINARY
}

When I try to install it on AIX 7.2, I get:

# rpm -i jload-AIX-1.1.3-1.noarch.rpm
        package jload-AIX-0:1.1.3-1.noarch is intended for a different operating system

I can use the --ignoreos flag, and it installs just fine (as a noarch package). But this I can also do with the rpm package build with os = Os.LINUX. Not sure what to make of this. My skills are not up to doing any major code changes, but I would like test or help otherwise.

mnellemann avatar May 22 '21 15:05 mnellemann