nebari icon indicating copy to clipboard operation
nebari copied to clipboard

[MAINT] - Move docker-images repo back to main nebari's repo

Open viniciusdc opened this issue 1 year ago • 5 comments

Context

Currently, our Docker images are maintained separately from our main source code. They are located at https://github.com/nebari-dev/nebari-docker-images/. This setup often leads to issues when releasing or merging changes to that separate repository. This is because it can result in errors if the Docker images are not fully tested in sync with the main source code. For example, updates made to the docker images won't necessarily be tested with the current head of the main branch.

We need to move the docker images into a docker folder within this repo and update the ci/cd so that images are built and tested as part of our regular test suite.

Value and/or benefit

  • better testability and issue tracking
  • Validate changes to docker images are not breaking
  • Simplify release process

Anything else?

No response

viniciusdc avatar Dec 03 '24 16:12 viniciusdc

Kindly explain a bit, if creating a Dockerfile on the main branch for the application solves this issue, then I can start working on it. Or it needs something else to test the synchronization status with the main branch.

Helion55 avatar Jan 15 '25 04:01 Helion55

Hey @Helion55 , I will update the issue description with more details. But the gist of it is to move our nebari-dev/docker-images repo into this one. Possibly, under a folder names docker or similar. The main reason for this, is due to it been quite troublessome to test changes in those without fully running this repo's integration tests. There have been a few instances where bugs were created due to not proper testing with this repo

viniciusdc avatar Jan 22 '25 16:01 viniciusdc

I updated the issue @Helion55, I hope that clarifies things

dcmcand avatar Jan 28 '25 11:01 dcmcand

Thanks, @dcmcand, I got the idea and am starting to work on it.

Helion55 avatar Jan 29 '25 03:01 Helion55

Hey @Helion55, we will be making a few changes to the Docker images repo to make it cleaner and easier to migrate. I will include this issue in a significant milestone to consolidate this work, and PR will be the first. Thanks again for the PR!

viniciusdc avatar Mar 17 '25 15:03 viniciusdc