nebari icon indicating copy to clipboard operation
nebari copied to clipboard
verified publisher icon nebari-dev

[ENH] Move Vault secrets and provider auth to custom action

Open viniciusdc opened this issue 1 year ago • 1 comments

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds a feature)
  • [ ] Breaking change (fix or feature that would cause existing features not to work as expected)
  • [ ] Documentation Update
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no API changes)
  • [ ] Build related changes
  • [ ] Other (please describe):

Testing

  • [ ] Did you test the pull request locally?
  • [ ] Did you add new tests?

How to test this PR?

Any other comments?

viniciusdc avatar Oct 05 '24 11:10 viniciusdc

@viniciusdc is this ready for review? Is there an associated issue?

marcelovilla avatar Oct 25 '24 08:10 marcelovilla

@viniciusdc with Vault failing relatively frequently, I'm wondering if we should consider just using GitHub secrets instead. Any thoughts?

C.C. @Adam-D-Lewis @dcmcand

marcelovilla avatar Nov 06 '24 15:11 marcelovilla

I would be in favor of moving away from vault

dcmcand avatar Nov 06 '24 15:11 dcmcand

I opened https://github.com/nebari-dev/nebari/issues/2835

marcelovilla avatar Nov 08 '24 10:11 marcelovilla

We're going to address https://github.com/nebari-dev/nebari/issues/2835 so we won't be merging this PR

marcelovilla avatar Nov 12 '24 15:11 marcelovilla