nebari icon indicating copy to clipboard operation
nebari copied to clipboard

Validate instance types for GCP

Open blakerosenthal opened this issue 1 year ago • 2 comments

Reference Issues or PRs

Closes https://github.com/nebari-dev/nebari/issues/2718

Adds back the instances(region:str) function to the GCP provider and validates available instances against the nebari config.

What does this implement/fix?

Put a x in the boxes that apply

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds a feature)
  • [ ] Breaking change (fix or feature that would cause existing features not to work as expected)
  • [ ] Documentation Update
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no API changes)
  • [ ] Build related changes
  • [ ] Other (please describe):

Testing

  • [x] Did you test the pull request locally?
  • [ ] Did you add new tests?

How to test this PR?

Check out and install this branch, then follow the instructions to deploy nebari on GCP. Run nebari validate -c nebari-config.yaml to validate available instance types.

Any other comments?

blakerosenthal avatar Sep 19 '24 20:09 blakerosenthal

@marcelovilla It looks like I'm missing a GOOGLE_CREDENTIALS environment variable in the tests. I spent some time with the test code trying to understand this but there's a lot of things that are instantiated at runtime. Is it obvious to you what's failing here?

https://github.com/nebari-dev/nebari/actions/runs/10948510295/job/30399687802?pr=2730

blakerosenthal avatar Sep 19 '24 21:09 blakerosenthal

@blakerosenthal I'll take a look at this tomorrow! Thanks for working on this 🚀

marcelovilla avatar Sep 24 '24 01:09 marcelovilla

@blakerosenthal if you have a moment, can you update the tests for this?

dcmcand avatar Nov 15 '24 13:11 dcmcand