nebari icon indicating copy to clipboard operation
nebari copied to clipboard

Make CI/CD Cloud Provider Test Conditional

Open tylergraff opened this issue 1 year ago • 1 comments

Reference Issues or PRs

What does this implement/fix?

The cloud provider CI/CD test fails when run from forks of this repo which do not have credentials (and presumably, their own accounts) set up for the providers used by the test. This situation generates spurious CI/CD pipeline failure messages.

This PR adds the ability for repo fork maintainers to skip the CI/CD Cloud Provider Test by setting a repo variable 'NO_PROVIDER_CREDENTIALS'. If that variable is not set by the repo maintainer (the default case), the test behavior will be unchanged from before this PR.

Put a x in the boxes that apply

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds a feature)
  • [ ] Breaking change (fix or feature that would cause existing features not to work as expected)
  • [ ] Documentation Update
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no API changes)
  • [X] Build related changes
  • [ ] Other (please describe):

Testing

  • [X] Did you test the pull request locally?
  • [ ] Did you add new tests?

Any other comments?

tylergraff avatar Mar 28 '24 14:03 tylergraff

@tylergraff is there an existing issue for this we can reference? If not, would you mind creating one?

marcelovilla avatar Apr 01 '24 19:04 marcelovilla

@marcelovilla I just created this issue for reference: refs https://github.com/nebari-dev/nebari/issues/2379

tylergraff avatar Apr 03 '24 19:04 tylergraff