nebari icon indicating copy to clipboard operation
nebari copied to clipboard

Remove files related to cypress

Open dcmcand opened this issue 11 months ago • 1 comments

dcmcand avatar Mar 18 '24 15:03 dcmcand

See #2075 for progress done in the past regarding the migration of Cypress to Playwright.

marcelovilla avatar Mar 18 '24 21:03 marcelovilla

I went over our Cypress tests and they perform the following actions:

  1. Login to Nebari
  2. Run a notebook
  3. Visit different services URLs (i.e., keycloak, conda-store, and grafana); there's no interaction with these, however.

Our Playwright tests already take care of (1) and (2). Regarding (3):

  • We're already implicitly testing keycloak's availability when logging in.
  • We have a test for Grafana which implicitly tests the existence of the service (by accessing the API).
  • We don't have anything that tests conda-store's availability for local tests as far as I am aware. We do have a health check for cloud tests, though.

While #2075 takes care of removing all cypress-related files, it is only migrating (1) to Playwright. I could migrate (3) to Playwright (it's not too much effort) but I don't think it will be beneficial, except from maybe catching conda-store not being available in the local integration tests.

Eventually, I'd like to incorporate different user journeys regarding these services, whether that involves UI testing or not.

Happy to hear your opinions here.

I am including @Adam-D-Lewis in the conversation.

marcelovilla avatar Apr 05 '24 16:04 marcelovilla