nebari icon indicating copy to clipboard operation
nebari copied to clipboard

[BUG] - Invalid `c.Historymanager.enabled` setting

Open krassowski opened this issue 3 months ago • 0 comments

Describe the bug

This is purported to disable history manager in ipython:

https://github.com/nebari-dev/nebari/blob/9f2f8c513de6c81b4c2c9e6c7b3ca93c3ac74f37/src/_nebari/stages/kubernetes_services/template/modules/kubernetes/services/jupyterhub/files/ipython/ipython_config.py#L3-L5

which I do not necessarily agree because in JupyterLab 4.1 the kernel history is used for inline completer and for searching in history (see https://jupyterlab.readthedocs.io/en/latest/getting_started/changelog.html#v4-1)

The issue is that it has no effect because the correct trait name is c.HistoryManager.enabled (upper case M).

Expected behavior

  • the correct trait name is used AND the fact that history is disabled for ipykernel (and hence a subpar user experience is offered with some features not working) is documented for users AND maybe there is a way to enable the history from nebar config file, OR
  • instead of disabling the history, the history manager is reconfigured so that it places the sqlite file in a more suitable location (since I infer that NFS is unsuitable for this purpose on nebari deployments)

OS and architecture in which you are running Nebari

2024.3.1

How to Reproduce the problem?

You can confirm this manually by starting ipython --HistoryManager.enabled=false vs ipython --Historymanager.enabled=false. You will see that in former you cannot navigate in history (e.g. using up arrow key) because there is no history, but that you can do in the latter.

On deployed nebari you can also got to Settings → Inline Completer → History provider → check enabled and try to type something in the notebook that you already executed; if prefix matches you will see suggestions from your history, even though this is supposed to be disabled

Command output

No response

Versions and dependencies used.

No response

Compute environment

None

Integrations

No response

Anything else?

All new settings should be verified in some way. I do not know what is the best way yet.

krassowski avatar Mar 12 '24 11:03 krassowski