nebari icon indicating copy to clipboard operation
nebari copied to clipboard

[BUG] - Config generated by guided init should contain default settings

Open rsignell opened this issue 1 year ago • 6 comments

Describe the bug

We generated a config using guided-init , and deployed Nebari on AWS with no apparent issues.

We then tried to use the deployment for training and students were not able to get the 30 workers they requested. We double checked our service quota in the region we were running the training and it was set to 500.
So we were mystified (and frustrated) why things weren't working.

Then after the training we realized that the generated config didn't contain the node groups section with the max limits for the different worker pools. In other words, the amazon section just looked like:

amazon_web_services:
  kubernetes_version: '1.26'
  region: us-west-2

So I imagine we were just getting the default max, which must have been something small.

When I added the section to:

amazon_web_services:
  kubernetes_version: '1.26'
  region: us-west-2
  node_groups:
    general:
      instance: m5.2xlarge
      min_nodes: 1
      max_nodes: 1
    user:
      instance: m5.xlarge
      min_nodes: 1
      max_nodes: 100
    worker:
      instance: m5.xlarge
      min_nodes: 1
      max_nodes: 450

and rerendered and redeployed, multiple students could spin up clusters of 30 again.

Expected behavior

The expected behaviour would be to have the guided-init create a config that contains the default settings so they could (1) show the user what the defaults were, and (2) provide a template that facilitates easy modification by the user.

OS and architecture in which you are running Nebari

aws

How to Reproduce the problem?

use the guided init on aws

Command output

No response

Versions and dependencies used.

nebari 2023.10.1

Compute environment

AWS

Integrations

No response

Anything else?

No response

rsignell avatar Nov 18 '23 07:11 rsignell